feat(OKISO): Add activity#10778
Closed
okisooo wants to merge 1 commit into
Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ], | ||
| "regExp": ".*(okiso\\.net|localhost).*", | ||
| "version": "1.0.0", | ||
| "logo": "https://i.imgur.com/LLE4SVZ.png", |
| @@ -0,0 +1,93 @@ | |||
| import { Presence, PresenceData, ActivityType, Assets, getTimestampsFromMedia } from 'premid' | |||
| @@ -0,0 +1,93 @@ | |||
| import { Presence, PresenceData, ActivityType, Assets, getTimestampsFromMedia } from 'premid' | |||
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new PreMiD activity integration for okiso.net, intended to display Rich Presence for browsing, live Twitch streams, video playback, discography navigation, and Terms of Service viewing.
Changes:
- Added OKISO activity presence implementation (
presence.ts) with page-based status detection. - Added OKISO activity metadata (
metadata.json) for service registration and store display. - Added a local
tsconfig.jsonextending the repo base config for building the activity.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
websites/O/OKISO/presence.ts |
Implements runtime presence detection for OKISO site pages and media states. |
websites/O/OKISO/metadata.json |
Registers the OKISO service (schema, URLs, regex, branding, tags). |
websites/O/OKISO/tsconfig.json |
Adds a TypeScript config extending the repo base config for compilation output. |
Comments suppressed due to low confidence (1)
websites/O/OKISO/presence.ts:22
presenceDatais cast toany, which removes type-safety and makes it easier to accidentally set invalid presence fields (and can mask mistakes during development). Prefer declaring it asPresenceData(optionally with a small helper type forbuttons) and onlydelete/mutate known keys.
const presenceData = {
largeImageKey: ActivityAssets.Logo,
largeImageText: 'okiso.net',
startTimestamp: browsingTimestamp,
buttons: [
{ label: 'Visit okiso.net', url: `https://okiso.net${pathname === '/' ? '' : pathname}` }
]
} as any
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,93 @@ | |||
| import { Presence, PresenceData, ActivityType, Assets, getTimestampsFromMedia } from 'premid' | |||
Comment on lines
+3
to
+4
| // Initialize without a custom clientId to use official PreMiD Application | ||
| const presence = new Presence() |
| const browsingTimestamp = Math.floor(Date.now() / 1000) | ||
|
|
||
| enum ActivityAssets { | ||
| Logo = 'logo', |
Comment on lines
+19
to
+21
| buttons: [ | ||
| { label: 'Visit okiso.net', url: `https://okiso.net${pathname === '/' ? '' : pathname}` } | ||
| ] |
| "okiso.net", | ||
| "localhost" | ||
| ], | ||
| "regExp": ".*(okiso\\.net|localhost).*", |
Author
|
closing this, my agent just completely me ignored saying i don't wanna PR (atleast not yet lol) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new activity for okiso.net. Tracks live Twitch streams, video playback, 3D discography navigation, and reading the Terms of Service.
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected
(Will add screenshots later if requested by reviewers)